{ - template.map(util.range(0, maxItems * 2), function (i) + template.map(util.range(0, options["maxitems"] * 2), function (i)

) @@ -1818,7 +1821,7 @@ function ItemList(id) //{{{ * Uses the entries in "items" to fill the listbox and does incremental * filling to speed up things. * - * @param {number} offset Start at this index and show maxItems. + * @param {number} offset Start at this index and show options["maxitems"]. */ function fill(offset) { @@ -1828,11 +1831,11 @@ function ItemList(id) //{{{ return false; startIndex = offset; - endIndex = Math.min(startIndex + maxItems, items.allItems.items.length); + endIndex = Math.min(startIndex + options["maxitems"], items.allItems.items.length); let haveCompletions = false; let off = 0; - let end = startIndex + maxItems; + let end = startIndex + options["maxitems"]; function getRows(context) { function fix(n) Math.max(0, Math.min(len, n)); @@ -1946,6 +1949,8 @@ function ItemList(id) //{{{ let sel = selIndex; let len = items.allItems.items.length; let newOffset = startIndex; + let maxItems = options["maxitems"]; + let contextLines = (maxItems > 3)? 3 : Math.max(0, maxItems - 1); if (index == -1 || index == null || index == len) // wrapped around { @@ -1956,10 +1961,10 @@ function ItemList(id) //{{{ } else { - if (index <= startIndex + CONTEXT_LINES) - newOffset = index - CONTEXT_LINES; - if (index >= endIndex - CONTEXT_LINES) - newOffset = index + CONTEXT_LINES - maxItems + 1; + if (index <= startIndex + contextLines) + newOffset = index - contextLines; + if (index >= endIndex - contextLines) + newOffset = index + contextLines - maxItems + 1; newOffset = Math.min(newOffset, len - maxItems); newOffset = Math.max(newOffset, 0); diff --git a/vimperator/NEWS b/vimperator/NEWS index b5751b5..5603ff6 100644 --- a/vimperator/NEWS +++ b/vimperator/NEWS @@ -5,6 +5,7 @@ * add ' and " local marks * add "w" and "W" Normal mode mappings for symmetry with o/O and t/T * add :messclear + * add 'maxitems' configuration variable 2009-03-28: * version 2.0 diff --git a/vimperator/locale/en-US/options.txt b/vimperator/locale/ en-US/options.txt index c434cb7..7b4a529 100644 --- a/vimperator/locale/en-US/options.txt +++ b/vimperator/locale/en-US/options.txt @@ -480,6 +480,12 @@ load plugins earlier, use the [c]:loadplugins[c] command within the vimperatorrc. ____ +|\'maxitems'| +||'maxitems'|| number (default: 20) +____ +Maximum number of items to display at once in a listing. +____ + |\'msgs'| |\'messages'| ||'messages' 'msgs'|| number (default: 100) -- 1.6.2 From maglione.k at gmail.com Sun Mar 29 13:30:04 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Sun, 29 Mar 2009 16:30:04 -0400 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: References: Message-ID: <20090329203004.GA15101@jg.home> On Sun, Mar 29, 2009 at 10:30:45PM +0300, Jarkko Oranen wrote: > Hello. > > Here's a simple patch to make the number of items shown in a listing > configurable. It defaults to 20, which was the previously hardcoded > value. > > I hope the patch comes through intact, as I'm using Mail.app to send > this. Hi, Thanks, I'd be happy to apply this patch, but please send it as an attachment; your mail client has wrapped several lines. -- Kris Maglione There are two ways to write error-free programs; only the third works. --Alan J. Perlis From chousuke at gmail.com Sun Mar 29 13:41:51 2009 From: chousuke at gmail.com (Jarkko Oranen) Date: Sun, 29 Mar 2009 23:41:51 +0300 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: <20090329203004.GA15101@jg.home> References: <20090329203004.GA15101@jg.home> Message-ID: On 29 Mar 2009, at 23:30, Kris Maglione wrote: > Hi, > > Thanks, I'd be happy to apply this patch, but please send it as an > attachment; your mail client has wrapped several lines. Agh, just what I feared. I don't know if Mail.app handles attachments correctly either, so just in case, the patch is also available at http://www.modeemi.fi/~oranenj/0001-Make-maxitems-configurable.patch -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Make-maxitems-configurable.patch Type: application/octet-stream Size: 4676 bytes Desc: not available URL: -------------- next part -------------- From dpb at driftaway.org Sun Mar 29 15:42:59 2009 From: dpb at driftaway.org (Daniel Bainton) Date: Mon, 30 Mar 2009 01:42:59 +0300 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: References: <20090329203004.GA15101@jg.home> Message-ID: 2009/3/29 Jarkko Oranen : > On 29 Mar 2009, at 23:30, Kris Maglione wrote: >> >> Hi, >> >> Thanks, I'd be happy to apply this patch, but please send it as an >> attachment; your mail client has wrapped several lines. > > Agh, just what I feared. > I don't know if Mail.app handles attachments correctly either, so just in > case, the patch is also available at > http://www.modeemi.fi/~oranenj/0001-Make-maxitems-configurable.patch Committed your patch. Thanks. (sorry Kris, you were too slow. ;)) -- Daniel From maglione.k at gmail.com Sun Mar 29 15:58:02 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Sun, 29 Mar 2009 18:58:02 -0400 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: References: <20090329203004.GA15101@jg.home> Message-ID: <20090329225802.GB15101@jg.home> On Sun, Mar 29, 2009 at 11:41:51PM +0300, Jarkko Oranen wrote: > Agh, just what I feared. > I don't know if Mail.app handles attachments correctly either, so just > in case, the patch is also available at > http://www.modeemi.fi/~oranenj/0001-Make-maxitems-configurable.patch I don't know of a mail client that doesn't send plain-text attachments correctly, and I think that Mail.app is unusually well behaved for an email client. Thanks for the consideration, though. -- Kris Maglione Long hair minimizes the need for barbers; socks can be done without; one leather jacket solves the coat problem for many years; suspenders are superfluous. --Albert Einstein From maglione.k at gmail.com Sun Mar 29 22:31:30 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 01:31:30 -0400 Subject: [Vimperator] Insanity? Message-ID: <20090330053130.GA27077@jg.home> Is it just me, or did someone rebase the vimperator-2.1 branch onto the master branch (and incidentally not create a 2.0 branch before hand)? -- Kris Maglione Organizations which design systems are constrained to produce designs which are copies of the communication structures of these organizations. (For example, if you have four groups working on a compiler, you?ll get a 4-pass compiler) --Conway?s Law From dpb at driftaway.org Mon Mar 30 00:00:05 2009 From: dpb at driftaway.org (Daniel Bainton) Date: Mon, 30 Mar 2009 10:00:05 +0300 Subject: [Vimperator] Insanity? In-Reply-To: <20090330053130.GA27077@jg.home> References: <20090330053130.GA27077@jg.home> Message-ID: 2009/3/30 Kris Maglione : > Is it just me, or did someone rebase the vimperator-2.1 branch onto the > master branch (and incidentally not create a 2.0 branch before hand)? Yeah, Doug merged the branches. Why would that be insanity? That's what is going to be the next release. (And creating a 2.0 branch when/if we need to fix it (which I highly doubt we will do, we don't have the resources), creating a 2.0 branch will be a piece of cake, this isn't cvs/svn. No need to create it if it's not needed.) -- Daniel From maglione.k at gmail.com Mon Mar 30 00:53:02 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 03:53:02 -0400 Subject: [Vimperator] Insanity? In-Reply-To: References: <20090330053130.GA27077@jg.home> Message-ID: <20090330075302.GB27077@jg.home> On Mon, Mar 30, 2009 at 10:00:05AM +0300, Daniel Bainton wrote: >2009/3/30 Kris Maglione : >> Is it just me, or did someone rebase the vimperator-2.1 branch onto the >> master branch (and incidentally not create a 2.0 branch before hand)? > >Yeah, Doug merged the branches. Why would that be insanity? That's >what is going to be the next release. (And creating a 2.0 branch >when/if we need to fix it (which I highly doubt we will do, we don't >have the resources), creating a 2.0 branch will be a piece of cake, >this isn't cvs/svn. No need to create it if it's not needed.) He didn't merge, he rebased. If he'd merged, we'd still have a coherent revision history, and I wouldn't have had to throw away my local repo and start from scratch. And, as he rebased, there doesn't appear to be a way to salvage the 2.0 line without another copy of the repo, which I have not. -- Kris Maglione The first 90% of the code accounts for the first 90% of the development time. The remaining 10% of the code accounts for the other 90% of the development time. --Tom Cargill From dpb at driftaway.org Mon Mar 30 01:14:05 2009 From: dpb at driftaway.org (Daniel Bainton) Date: Mon, 30 Mar 2009 10:14:05 +0200 Subject: [Vimperator] Insanity? In-Reply-To: <20090330075302.GB27077@jg.home> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> Message-ID: 2009/3/30 Kris Maglione : > On Mon, Mar 30, 2009 at 10:00:05AM +0300, Daniel Bainton wrote: >> >> 2009/3/30 Kris Maglione : >>> >>> Is it just me, or did someone rebase the vimperator-2.1 branch onto the >>> master branch (and incidentally not create a 2.0 branch before hand)? >> >> Yeah, Doug merged the branches. Why would that be insanity? That's >> what is going to be the next release. (And creating a 2.0 branch >> when/if we need to fix it (which I highly doubt we will do, we don't >> have the resources), creating a 2.0 branch will be a piece of cake, >> this isn't cvs/svn. No need to create it if it's not needed.) > > He didn't merge, he rebased. If he'd merged, we'd still have a coherent > revision history, and I wouldn't have had to throw away my local repo and > start from scratch. And, as he rebased, there doesn't appear to be a way to > salvage the 2.0 line without another copy of the repo, which I have not. I don't see anything wrong in the revision history. Looks like a merge to me, the commit hashes are the same in both branches, and the 2.1 commits surely aren't on top of the 2.0 commits. git checkout -b vimperator-2.0 VIMPERATOR_2_0 That gives you the 2.0 branch if for some reason you need it. -- Daniel From ted at tedpavlic.com Mon Mar 30 06:32:03 2009 From: ted at tedpavlic.com (Ted Pavlic) Date: Mon, 30 Mar 2009 09:32:03 -0400 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: <20090329203004.GA15101@jg.home> References: <20090329203004.GA15101@jg.home> Message-ID: <49D0C9D3.7010500@tedpavlic.com> > Thanks, I'd be happy to apply this patch, but please send it as > an attachment; your mail client has wrapped several lines. That appears to be due to Mail.app sending things as "format=flowed" by default. Content-Type: text/plain; charset="us-ascii"; Format="flowed"; DelSp="yes" I've searched, but I can't find a way to disable this Mail.app behavior. If anyone knows how to disable Mail.app's format=flowed, please share. If someone could get rid of it, then people could send patches as plain text e-mails without having to worry about such things. -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS. From maglione.k at gmail.com Mon Mar 30 06:49:26 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 09:49:26 -0400 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: <49D0C9D3.7010500@tedpavlic.com> References: <20090329203004.GA15101@jg.home> <49D0C9D3.7010500@tedpavlic.com> Message-ID: <20090330134926.GC27077@jg.home> On Mon, Mar 30, 2009 at 09:32:03AM -0400, Ted Pavlic wrote: > If anyone knows how to disable Mail.app's format=flowed, please share. > If someone could get rid of it, then people could send patches as plain > text e-mails without having to worry about such things. Don't disable format=flowed; it won't help. If anything, disable wrapping, but don't do that either. Just send as an attachment. -- Kris Maglione It is a farce to call any being virtuous whose virtues do not result from the exercise of its own reason. --Mary Wollstonecraft From ted at tedpavlic.com Mon Mar 30 06:49:44 2009 From: ted at tedpavlic.com (Ted Pavlic) Date: Mon, 30 Mar 2009 09:49:44 -0400 Subject: [Vimperator] Insanity? In-Reply-To: References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> Message-ID: <49D0CDF8.1070805@tedpavlic.com> > git checkout -b vimperator-2.0 VIMPERATOR_2_0 I agree that it would be a nice organizational move to create an explicit vimperator-2.0 branch. At the moment, origin/master is unusable (at least on my OS X machine). The JavaScript console is filled with errors before hardly any of my vimperatorrc loads. So just for distribution sake (I think many people are git'ting Vimp from source rather than from XPI), it would be nice to have a stable origin/vimperator-2.0 branch that observers could follow. --Ted -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS. From ted at tedpavlic.com Mon Mar 30 06:58:31 2009 From: ted at tedpavlic.com (Ted Pavlic) Date: Mon, 30 Mar 2009 09:58:31 -0400 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: <20090330134926.GC27077@jg.home> References: <20090329203004.GA15101@jg.home> <49D0C9D3.7010500@tedpavlic.com> <20090330134926.GC27077@jg.home> Message-ID: <49D0D007.4070201@tedpavlic.com> > Don't disable format=flowed; it won't help. If anything, disable > wrapping, but don't do that either. Just send as an attachment. If you don't disable format=flowed, then disabling wrapping won't help. You have to do them both. On the git list, people submit patches a plain text e-mails, which get critiqued on-line by many readers of the list. Once there's consensus, the patch gets applied by a single master of the git repo. It's a nice way to collaborate -- lots of people get to participate and there's still a gatekeeper who prevents chaos in the repo. All of that's possible because of plain text non-flowed patches (which is one reason why "git send-email" and friends exist). Maybe it's not an appropriate dev environment for Vimperator, but it works very well for git. --Ted -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS. From dpb at driftaway.org Mon Mar 30 07:02:05 2009 From: dpb at driftaway.org (Daniel Bainton) Date: Mon, 30 Mar 2009 17:02:05 +0300 Subject: [Vimperator] Insanity? In-Reply-To: <49D0CDF8.1070805@tedpavlic.com> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <49D0CDF8.1070805@tedpavlic.com> Message-ID: 2009/3/30 Ted Pavlic : >> git checkout -b vimperator-2.0 VIMPERATOR_2_0 > > I agree that it would be a nice organizational move to create an explicit > vimperator-2.0 branch. > > At the moment, origin/master is unusable (at least on my OS X machine). The > JavaScript console is filled with errors before hardly any of my > vimperatorrc loads. > > So just for distribution sake (I think many people are git'ting Vimp from > source rather than from XPI), it would be nice to have a stable > origin/vimperator-2.0 branch that observers could follow. They can just use the VIMPERATOR_2_0 tag if they want a stable branch. IMHO there's absolutely no need to create a branch for 2.0 if it's not going to be used. *If* someone will backport some fix for 2.0, *then* the branch can be created, but atleast I wont be doing that. origin/master works on my linux machines just fine. (Except for the few config.focusChange is not a function errors..) -- Daniel From chousuke at gmail.com Mon Mar 30 07:16:28 2009 From: chousuke at gmail.com (Jarkko Oranen) Date: Mon, 30 Mar 2009 17:16:28 +0300 Subject: [Vimperator] [PATCH] UI tweak when maxitems < 7 Message-ID: <06210CA1-0EB3-4356-90A3-5B82027158AE@gmail.com> Hello again. I noticed the UI behaves a bit erratically when maxitems is set to less than 7 because of how the number of context lines is calculated. Attached patch fixes it, and also sets the validator function to require maxitems >= 1, as I was told that to disable listing, one should use the wildmode setting instead. maxitems at 1 is probably not going to be a popular setting either, but I thought it wouldn't hurt to allow it. -- Jarkko -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-UI-tweak-when-maxitems-7.patch Type: application/octet-stream Size: 1250 bytes Desc: not available URL: -------------- next part -------------- From stubenschrott at vimperator.org Mon Mar 30 07:20:53 2009 From: stubenschrott at vimperator.org (Martin Stubenschrott) Date: Mon, 30 Mar 2009 16:20:53 +0200 Subject: [Vimperator] Insanity? In-Reply-To: References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <49D0CDF8.1070805@tedpavlic.com> Message-ID: <49D0D545.8050006@vimperator.org> On 03/30/2009 04:02 PM, Daniel Bainton wrote: > They can just use the VIMPERATOR_2_0 tag if they want a stable branch. > IMHO there's absolutely no need to create a branch for 2.0 if it's not > going to be used. *If* someone will backport some fix for 2.0, *then* > the branch can be created, but atleast I wont be doing that. Yeah, I agree. We don't plan to do a 2.0.1 follow up release, until massive amounts of people complain, and then we'll just create a branch off the 2.0 tag. Whether merging or rebasing is better, I have no idea, since i am no VCS guru, but master should always be the latest branch where development occurs, unless we plan to stabilize before a release. Maybe we should discuss such things first, but all people on IRC seemed to agree on that, and I hope Kris doesn't have to redo all his changes. -- Martin From dpb at driftaway.org Mon Mar 30 07:22:18 2009 From: dpb at driftaway.org (Daniel Bainton) Date: Mon, 30 Mar 2009 17:22:18 +0300 Subject: [Vimperator] [PATCH] UI tweak when maxitems < 7 In-Reply-To: <06210CA1-0EB3-4356-90A3-5B82027158AE@gmail.com> References: <06210CA1-0EB3-4356-90A3-5B82027158AE@gmail.com> Message-ID: 2009/3/30 Jarkko Oranen : > Hello again. > > I noticed the UI behaves a bit erratically when maxitems is set to less than > 7 because of how > the number of context lines is calculated. > > Attached patch fixes it, and also sets the validator function to require > maxitems >= 1, as I was told that ?to disable listing, one should use the > wildmode setting instead. > > maxitems at 1 is probably not going to be a popular setting either, but I > thought it wouldn't hurt to allow it. Applied. Thanks. -- Daniel From maglione.k at gmail.com Mon Mar 30 07:27:28 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 10:27:28 -0400 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: <49D0D007.4070201@tedpavlic.com> References: <20090329203004.GA15101@jg.home> <49D0C9D3.7010500@tedpavlic.com> <20090330134926.GC27077@jg.home> <49D0D007.4070201@tedpavlic.com> Message-ID: <20090330142728.GD27077@jg.home> On Mon, Mar 30, 2009 at 09:58:31AM -0400, Ted Pavlic wrote: > On the git list, people submit patches a plain text e-mails, which get > critiqued on-line by many readers of the list. Once there's consensus, > the patch gets applied by a single master of the git repo. It's a nice > way to collaborate -- lots of people get to participate and there's > still a gatekeeper who prevents chaos in the repo. All of that's > possible because of plain text non-flowed patches (which is one reason > why "git send-email" and friends exist). You can send plain-text patches as attachments. If your mail client doesn't support MIME or can't display plain-text attachments inline, well... -- Kris Maglione Beware of bugs in the above code; I have only proved it correct, not tried it. --Donald Knuth From maglione.k at gmail.com Mon Mar 30 07:28:35 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 10:28:35 -0400 Subject: [Vimperator] Insanity? In-Reply-To: References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <49D0CDF8.1070805@tedpavlic.com> Message-ID: <20090330142835.GE27077@jg.home> On Mon, Mar 30, 2009 at 05:02:05PM +0300, Daniel Bainton wrote: >origin/master works on my linux machines just fine. (Except for the >few config.focusChange is not a function errors..) Sorry, that commit was somehow botched in the melee. -- Kris Maglione The best way to predict the future is to invent it. --Alan Kay From maglione.k at gmail.com Mon Mar 30 07:29:39 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 10:29:39 -0400 Subject: [Vimperator] Insanity? In-Reply-To: <49D0D545.8050006@vimperator.org> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <49D0CDF8.1070805@tedpavlic.com> <49D0D545.8050006@vimperator.org> Message-ID: <20090330142939.GF27077@jg.home> On Mon, Mar 30, 2009 at 04:20:53PM +0200, Martin Stubenschrott wrote: >Whether merging or rebasing is better, I have no idea, since i am no >VCS guru, but master should always be the latest branch where development >occurs, unless we plan to stabilize before a release. Rebasing is evil, except in a few rare cases. It should never be done on a public repo. -- Kris Maglione We should forget about small efficiencies, say about 97% of the time: premature optimization is the root of all evil. --Donald Knuth From ted at tedpavlic.com Mon Mar 30 07:42:55 2009 From: ted at tedpavlic.com (Ted Pavlic) Date: Mon, 30 Mar 2009 10:42:55 -0400 Subject: [Vimperator] Insanity? In-Reply-To: <20090330142939.GF27077@jg.home> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <49D0CDF8.1070805@tedpavlic.com> <49D0D545.8050006@vimperator.org> <20090330142939.GF27077@jg.home> Message-ID: <49D0DA6F.8030308@tedpavlic.com> > Rebasing is evil, except in a few rare cases. It should never be > done on a public repo. Maybe I'm missing something, but I don't see evidence of rebasing in the git repo I pulled down. git log --graph -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS. From ted at tedpavlic.com Mon Mar 30 07:43:46 2009 From: ted at tedpavlic.com (Ted Pavlic) Date: Mon, 30 Mar 2009 10:43:46 -0400 Subject: [Vimperator] Insanity? In-Reply-To: <49D0DA6F.8030308@tedpavlic.com> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <49D0CDF8.1070805@tedpavlic.com> <49D0D545.8050006@vimperator.org> <20090330142939.GF27077@jg.home> <49D0DA6F.8030308@tedpavlic.com> Message-ID: <49D0DAA2.9050801@tedpavlic.com> Disregard that. Thunderbird puts the little red "close this window" button very close to the default location for "Send this e-mail." > git log --graph -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS. From ted at tedpavlic.com Mon Mar 30 07:46:29 2009 From: ted at tedpavlic.com (Ted Pavlic) Date: Mon, 30 Mar 2009 10:46:29 -0400 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: <20090330142728.GD27077@jg.home> References: <20090329203004.GA15101@jg.home> <49D0C9D3.7010500@tedpavlic.com> <20090330134926.GC27077@jg.home> <49D0D007.4070201@tedpavlic.com> <20090330142728.GD27077@jg.home> Message-ID: <49D0DB45.9030305@tedpavlic.com> > You can send plain-text patches as attachments. If your mail > client doesn't support MIME or can't display plain-text > attachments inline, well... My point was that in-line messages can easily be quoted and critiqued. On the git list, there's a lot of... "I don't understand these lines" and "Couldn't you have done this differently here?" Usually plain-text attachments aren't quoted in responses. That's all I'm saying. -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS. From stubenschrott at vimperator.org Mon Mar 30 07:47:40 2009 From: stubenschrott at vimperator.org (Martin Stubenschrott) Date: Mon, 30 Mar 2009 16:47:40 +0200 Subject: [Vimperator] Insanity? In-Reply-To: <20090330142835.GE27077@jg.home> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <49D0CDF8.1070805@tedpavlic.com> <20090330142835.GE27077@jg.home> Message-ID: <49D0DB8C.6070802@vimperator.org> On 03/30/2009 04:28 PM, Kris Maglione wrote: > On Mon, Mar 30, 2009 at 05:02:05PM +0300, Daniel Bainton wrote: >>origin/master works on my linux machines just fine. (Except for the >>few config.focusChange is not a function errors..) > > Sorry, that commit was somehow botched in the melee. But thanks for the focusChange abstraction. Was due anyway, and seriously reduces the non-general code from liberator. From stubenschrott at vimperator.org Mon Mar 30 07:54:51 2009 From: stubenschrott at vimperator.org (Martin Stubenschrott) Date: Mon, 30 Mar 2009 16:54:51 +0200 Subject: [Vimperator] [PATCH] Make maxItems configurable In-Reply-To: <49D0DB45.9030305@tedpavlic.com> References: <20090329203004.GA15101@jg.home> <49D0C9D3.7010500@tedpavlic.com> <20090330134926.GC27077@jg.home> <49D0D007.4070201@tedpavlic.com> <20090330142728.GD27077@jg.home> <49D0DB45.9030305@tedpavlic.com> Message-ID: <49D0DD3B.6060305@vimperator.org> On 03/30/2009 04:46 PM, Ted Pavlic wrote: >> You can send plain-text patches as attachments. If your mail >> client doesn't support MIME or can't display plain-text >> attachments inline, well... > > My point was that in-line messages can easily be quoted and critiqued. > On the git list, there's a lot of... "I don't understand these lines" > and "Couldn't you have done this differently here?" > > Usually plain-text attachments aren't quoted in responses. That's all > I'm saying. Depends on your mail client, many will add plain text attachments in the reply, but your point is of course valid, it should be easy to comment on patches with most mail clients. From mftian at gmail.com Mon Mar 30 09:27:12 2009 From: mftian at gmail.com (Xie&Tian) Date: Tue, 31 Mar 2009 00:27:12 +0800 Subject: [Vimperator] Chinese translation of Vimperator docs is finished Message-ID: Hi The Chinese translation of Vimperator docs is finished (Google Code Project: http://code.google.com/p/cvimp/). Unfortunately I'm having some issue with asciidoc because it can't deal with non-English characters very well. I'm working on it. (If anyone is interested, you can take a look at janus_wel's post at asciidoc's googlegroup: http://groups.google.com/group/asciidoc/browse_thread/thread/c7851c7a1b442a0a. We're having the same problem) -- Xie PS: the command :tabnext and :tabprevious are not symmetry. Is that intended? From casey.manion at gmail.com Mon Mar 30 10:04:30 2009 From: casey.manion at gmail.com (Casey Manion) Date: Mon, 30 Mar 2009 10:04:30 -0700 Subject: [Vimperator] Error: config.focusChange is not a function Message-ID: <66dd0ce40903301004o86cfbe8je39b91297f931590@mail.gmail.com> Error: config.focusChange is not a function Source file: chrome://liberator/content/events.js Line: 1225 Change: if (config.focusChange()) To?: if (config.focusChange) Testing now... -Casey From maglione.k at gmail.com Mon Mar 30 10:14:35 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 13:14:35 -0400 Subject: [Vimperator] Error: config.focusChange is not a function In-Reply-To: <66dd0ce40903301004o86cfbe8je39b91297f931590@mail.gmail.com> References: <66dd0ce40903301004o86cfbe8je39b91297f931590@mail.gmail.com> Message-ID: <20090330171435.GG27077@jg.home> On Mon, Mar 30, 2009 at 10:04:30AM -0700, Casey Manion wrote: >Change: > if (config.focusChange()) > >To?: > if (config.focusChange) > >Testing now... I commited that very change some hours ago. -- Kris Maglione We should forget about small efficiencies, say about 97% of the time: premature optimization is the root of all evil. --Donald Knuth From maglione.k at gmail.com Mon Mar 30 17:16:11 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 20:16:11 -0400 Subject: [Vimperator] Chinese translation of Vimperator docs is finished In-Reply-To: References: Message-ID: <20090331001611.GJ27077@jg.home> On Tue, Mar 31, 2009 at 12:27:12AM +0800, Xie&Tian wrote: >The Chinese translation of Vimperator docs is finished (Google Code >Project: http://code.google.com/p/cvimp/). Unfortunately I'm having >some issue with asciidoc because it can't deal with non-English >characters very well. I'm working on it. > >(If anyone is interested, you can take a look at janus_wel's post at >asciidoc's googlegroup: >http://groups.google.com/group/asciidoc/browse_thread/thread/c7851c7a1b442a0a. >We're having the same problem) Awesome. See attachment for a horrifically mangled asciidoc that handles unicode. -- Kris Maglione If the code and the comments disagree, then both are probably wrong. --attributed to Norm Schryer From mftian at gmail.com Mon Mar 30 17:50:15 2009 From: mftian at gmail.com (Xie&Tian) Date: Tue, 31 Mar 2009 08:50:15 +0800 Subject: [Vimperator] Chinese translation of Vimperator docs is finished In-Reply-To: <20090331001611.GJ27077@jg.home> References: <20090331001611.GJ27077@jg.home> Message-ID: erf ... Kris, did you forget the attachment? 2009/3/31 Kris Maglione : > On Tue, Mar 31, 2009 at 12:27:12AM +0800, Xie&Tian wrote: >> >> The Chinese translation of Vimperator docs is finished (Google Code >> Project: http://code.google.com/p/cvimp/). Unfortunately I'm having >> some issue with asciidoc because it can't deal with non-English >> characters very well. I'm working on it. >> >> (If anyone is interested, you can take a look at janus_wel's post at >> asciidoc's googlegroup: >> >> http://groups.google.com/group/asciidoc/browse_thread/thread/c7851c7a1b442a0a. >> We're having the same problem) > > Awesome. See attachment for a horrifically mangled asciidoc that handles > unicode. > > -- > Kris Maglione > > If the code and the comments disagree, then both are probably wrong. > ? ? ? ?--attributed to Norm Schryer > > _______________________________________________ > Vimperator mailing list > Vimperator at mozdev.org > https://www.mozdev.org/mailman/listinfo/vimperator > From maglione.k at gmail.com Mon Mar 30 18:04:23 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Mon, 30 Mar 2009 21:04:23 -0400 Subject: [Vimperator] Chinese translation of Vimperator docs is finished In-Reply-To: References: <20090331001611.GJ27077@jg.home> Message-ID: <20090331010423.GK27077@jg.home> On Tue, Mar 31, 2009 at 08:50:15AM +0800, Xie&Tian wrote: >erf ... Kris, did you forget the attachment? No, long story. This is my third try, and was supposed to say: See liberator.git/contrib/ -- Kris Maglione A program that produces incorrect results twice as fast is infinitely slower. --John Osterhout From dougkearns at gmail.com Mon Mar 30 21:30:45 2009 From: dougkearns at gmail.com (Doug Kearns) Date: Tue, 31 Mar 2009 15:30:45 +1100 Subject: [Vimperator] Insanity? In-Reply-To: <20090330075302.GB27077@jg.home> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> Message-ID: <644fc65e0903302130k70cf552jb3dca571f625ad4@mail.gmail.com> On 3/30/09, Kris Maglione wrote: > He didn't merge, he rebased. If he'd merged, we'd still have a coherent > revision history, and I wouldn't have had to throw away my local repo and > start from scratch. And, as he rebased, there doesn't appear to be a way to > salvage the 2.0 line without another copy of the repo, which I have not. Hmm, wouldn't that require a git rebase somewhere? The shell history says: git checkout master git merge vimperator-2.1 git push Is something else going on? Doug [who should obviously never have listened to Cruise and stopped his meds] From maglione.k at gmail.com Mon Mar 30 21:43:19 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Tue, 31 Mar 2009 00:43:19 -0400 Subject: [Vimperator] Insanity? In-Reply-To: <644fc65e0903302130k70cf552jb3dca571f625ad4@mail.gmail.com> References: <20090330053130.GA27077@jg.home> <20090330075302.GB27077@jg.home> <644fc65e0903302130k70cf552jb3dca571f625ad4@mail.gmail.com> Message-ID: <20090331044319.GL27077@jg.home> On Tue, Mar 31, 2009 at 03:30:45PM +1100, Doug Kearns wrote: >Hmm, wouldn't that require a git rebase somewhere? The shell history says: > >git checkout master >git merge vimperator-2.1 >git push > >Is something else going on? No, apparantly my local just decided to blow up, or something. -- Kris Maglione The key to performance is elegance, not battalions of special cases. --Jon Bentley and Doug McIlroy From dougkearns at gmail.com Mon Mar 30 21:58:31 2009 From: dougkearns at gmail.com (Doug Kearns) Date: Tue, 31 Mar 2009 15:58:31 +1100 Subject: [Vimperator] Asciidoc and help system Message-ID: <644fc65e0903302158j66f6a977o34800addd21f067f@mail.gmail.com> Now that we have at least three apps with documentation updating the help is becoming an increasingly onerous task. Does anyone have any thoughts on a better way forward? Are we persevering with Asciidoc? Doug From mftian at gmail.com Mon Mar 30 23:17:51 2009 From: mftian at gmail.com (Xie&Tian) Date: Tue, 31 Mar 2009 14:17:51 +0800 Subject: [Vimperator] Asciidoc and help system In-Reply-To: <644fc65e0903302158j66f6a977o34800addd21f067f@mail.gmail.com> References: <644fc65e0903302158j66f6a977o34800addd21f067f@mail.gmail.com> Message-ID: 2009/3/31 Doug Kearns : > Now that we have at least three apps with documentation updating the > help is becoming an increasingly onerous task. > > Does anyone have any thoughts on a better way forward? Are we > persevering with Asciidoc? I think it's nothing to do with Asciidoc, it's the way we distribute localized documentation. I prefer Ted's suggestion which would place the documentations in ~/.vimperator/locale/doc directory. In addition, a ":installdoc [a][path/to/doc_zip_file][a] [a][locale_alias][a]" command can be added to automate the procedure of unzipping the downloaded doc package to ~/.vimperator/[locale_alias]/doc directory. The [locale_alias] argument is optional and can be extracted from the zip file name. It could then be used by 'helpfile' option to switch between docs of different lang. What do you think? -- Xie > > Doug > _______________________________________________ > Vimperator mailing list > Vimperator at mozdev.org > https://www.mozdev.org/mailman/listinfo/vimperator > From Daniel.Trstenjak at online.de Tue Mar 31 11:38:21 2009 From: Daniel.Trstenjak at online.de (Daniel Trstenjak) Date: Tue, 31 Mar 2009 20:38:21 +0200 Subject: [Vimperator] Disable automatic input box salection? In-Reply-To: <20090310191605.GA5791@laptop> References: <7f327d3151d4d0bda3ae695309d5d947.squirrel@www.hessiess.dyndns.org> <20090310191605.GA5791@laptop> Message-ID: <20090331183821.GC5827@laptop> On Tue, Mar 10, 2009 at 08:16:06PM +0100, Daniel Trstenjak wrote: > Put the file 'user.js' into '~/.mozilla/firefox//'. This doesn't work very well on some sides. It's better to explicit define the sides. (see attached 'user.js') Greetings, Daniel -------------- next part -------------- A non-text attachment was scrubbed... Name: user.js Type: application/javascript Size: 221 bytes Desc: not available URL: From ted at tedpavlic.com Tue Mar 31 16:14:09 2009 From: ted at tedpavlic.com (Ted Pavlic) Date: Tue, 31 Mar 2009 19:14:09 -0400 Subject: [Vimperator] New PATH_SEP stuff makes Vimp2.0 unusable on my OS X machine Message-ID: <49D2A3C1.3070904@tedpavlic.com> Sorry for posting this on the list rather than #irc. Not able to IRC at the moment. As of 228198545aea0119bd4829f221d594f87532af6a ===== commit 228198545aea0119bd4829f221d594f87532af6a Author: Kris Maglione Date: Wed Dec 24 13:22:54 2008 -0500 Cleanup io.js with relation to path separators ===== Vimperator2.0 has fatal execution errors on startup. In particular... (using that commit): ===== liberator: Loading script io.js: ReferenceError: services is not defined liberator: Loading script bookmarks.js: Error opening input stream (invalid filename?) vimperator: TypeError:? IO.runtimePath is undefined:: fileName: "chrome://liberator/content/liberator.js" lineNumber: 1231 message: "IO.runtimePath is undefined" stack: ([object Event])@chrome://liberator/content/liberator.js:1231 toString: function () error.toString() vimperator: vimperator: Loading module commands... vimperator: Loading module options... vimperator: Loading module mappings... vimperator: Loading module buffer... vimperator: Loading module events... vimperator: Loading module commandline... vimperator: Loading module statusline... vimperator: Loading module editor... vimperator: Loading module autocommands... vimperator: Loading module io... vimperator: Loading module completion... vimperator: TypeError:? func is undefined:: fileName: "chrome://liberator/content/completion.js" lineNumber: 1260 message: "func is undefined" stack: setFunctionCompleter([object Array],[object Array])@chrome://liberator/content/completion.js:1260 ("completion")@chrome://liberator/content/io.js:383 ("load_completion","completion")@chrome://liberator/content/liberator.js:658 loadModule("completion",Completion)@chrome://liberator/content/liberator.js:81 ([object Event])@chrome://liberator/content/liberator.js:1254 toString: function () error.toString() vimperator: vimperator: Loading module search... vimperator: Loading module bookmarks... vimperator: Loading module history... vimperator: Loading module tabs... vimperator: Loading module marks... vimperator: Loading module quickmarks... vimperator: Loading module hints... vimperator: loaded in 1289 ms ===== Things are only worse in origin/master. ===== liberator: Loading script io.js: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsILocalFile.append]" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: chrome://liberator/content/io.js :: anonymous :: line 1105" data: no] vimperator: TypeError:? IO.runtimePath is undefined:: fileName: "chrome://liberator/content/liberator.js" lineNumber: 1248 message: "IO.runtimePath is undefined" stack: ([object Event])@chrome://liberator/content/liberator.js:1248 toString: function () error.toString() vimperator: vimperator: Loading module commands... vimperator: Loading module options... vimperator: Loading module mappings... vimperator: Loading module buffer... vimperator: Loading module events... vimperator: Loading module commandline... vimperator: Loading module statusline... vimperator: Loading module editor... vimperator: Loading module autocommands... vimperator: Loading module io... vimperator: Loading module completion... vimperator: TypeError:? func is undefined:: fileName: "chrome://liberator/content/completion.js" lineNumber: 1295 message: "func is undefined" stack: setFunctionCompleter([object Array],[object Array])@chrome://liberator/content/completion.js:1295 ("completion")@chrome://liberator/content/io.js:389 ("load_completion","completion")@chrome://liberator/content/liberator.js:659 loadModule("completion",Completion)@chrome://liberator/content/liberator.js:80 ([object Event])@chrome://liberator/content/liberator.js:1269 toString: function () error.toString() vimperator: vimperator: Loading module search... vimperator: Loading module bookmarks... vimperator: Loading module history... vimperator: Loading module tabs... vimperator: Loading module marks... vimperator: Loading module quickmarks... vimperator: Loading module hints... vimperator: loaded in 600 ms ===== Side note: I also get two (very old?) CSS/JS warnings on the JS error console: ===== Warning: Unknown pseudo-class or pseudo-element 'first-of-type'. Malformed simple selector as negation pseudo-class argument 'first-of-type'. Ruleset ignored due to bad selector. Source File: chrome-data://text/css, at namespace%20html%20%22http://www.w3.org/1999/xhtml%22;%0A at namespace%20xul%20%22http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul%22;%0A at namespace%20liberator%20%22http://vimperator.org/namespaces/liberator%22;%0A at -moz-document%20url(%22chrome://liberator/content/buffer.xhtml%22),%20url(%22chrome://browser/content/browser.xul%22)%7B%0A%5Bliberator%7Chighlight~=CompGroup%5D:not(:first-of-type)%20%7B%20margin-top:%20.5em!important;%20%7D%0A%7D%0A Line: 5 Warning: Unknown pseudo-class or pseudo-element 'first-of-type'. Malformed simple selector as negation pseudo-class argument 'first-of-type'. Ruleset ignored due to bad selector. Source File: chrome-data://text/css, at namespace%20html%20%22http://www.w3.org/1999/xhtml%22;%0A at namespace%20xul%20%22http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul%22;%0A at namespace%20liberator%20%22http://vimperator.org/namespaces/liberator%22;%0A at -moz-document%20url(%22chrome://liberator/content/buffer.xhtml%22),%20url(%22chrome://browser/content/browser.xul%22)%7B%0A%5Bliberator%7Chighlight~=CompGroup%5D:not(:first-of-type)%20%7B%20margin-top:%20.5em!important;%20%7D%0A%7D%0A Line: 5 ===== --Ted -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS. From maglione.k at gmail.com Tue Mar 31 19:18:31 2009 From: maglione.k at gmail.com (Kris Maglione) Date: Tue, 31 Mar 2009 22:18:31 -0400 Subject: [Vimperator] New PATH_SEP stuff makes Vimp2.0 unusable on my OS X machine In-Reply-To: <49D2A3C1.3070904@tedpavlic.com> References: <49D2A3C1.3070904@tedpavlic.com> Message-ID: <20090401021831.GM27077@jg.home> On Tue, Mar 31, 2009 at 07:14:09PM -0400, Ted Pavlic wrote: > ===== > Warning: Unknown pseudo-class or pseudo-element 'first-of-type'. > Malformed simple selector as negation pseudo-class argument > 'first-of-type'. Ruleset ignored due to bad selector. > Source File: > chrome-data://text/css, at namespace%20html%20%22http://www.w3.org/1999/xhtml%22;%0A at namespace%20xul%20%22http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul%22;%0A at namespace%20liberator%20%22http://vimperator.org/namespaces/liberator%22;%0A at -moz-document%20url(%22chrome://liberator/content/buffer.xhtml%22),%20url(%22chrome://browser/content/browser.xul%22)%7B%0A%5Bliberator%7Chighlight~=CompGroup%5D:not(:first-of-type)%20%7B%20margin-top:%20.5em!important;%20%7D%0A%7D%0A > Line: 5 Use FF 3.1 (it's a requirement for 2.1, anyway). It's probably the solution to the other problem too, but I don't know why the other problem might occur. -- Kris Maglione Memory is like an orgasm. It's a lot better if you don't have to fake it. --Seymour Cray