[Vimperator] Vimperator Src Patch

[Martin Stubenschrott]

Konstantin wrote:

> Its Konstantin again.

Hi :)

> I'm still working on tuning Vimperator and found out
> it doesn't handle "save" and "yank" operations on objects
> selected with QuickHints mode if the object have "src" attr
> rather than "href" (e.g. <img>, which I was added into hinttags
> to save images on page).
> Unfortunately I couldn't find a way to add this feature w/o
> modifing extension's source (e.g. by putting it into plugin).
> Here's my patch to to fix it (hints.js file):
> 
> 616c616
> <                 tmp = elems[i].refElem.href;
> ---
>>                 tmp = elems[i].refElem.href || elems[i].refElem.src;
> 662c662
> <                 var url = makeURLAbsolute(elems[i].refElem.baseURI, elems[i].refElem.href);
> ---
>>                 var url = makeURLAbsolute(elems[i].refElem.baseURI, elems[i].refElem.href || elems[i].refElem.src);
> 
> 
> I thought it whould be good to include this functionality into Vimperator,
> so it is 1) accessible to all other people, 2) it won't be necessary
> to patch your extension every time it is updated.

Sure, I am *very* open for bug fixes and new features in the vimperator
source, if they would benefit more users.

However, the 0.5.x branch wasn't updated for months as we are working
really hard on the 0.6 branch (which is Firefox3beta only however). In
that branch hints were totally rewritten.

While I still want to include your patch, i would need an updated one
for the 0.6 branch. You can get it with the instructions from there:

http://vimperator.mozdev.org/source.html

Also please use "diff -u" instead of just "diff". "Unified" diffs are
much better readable for review.

--
Martin

PS: Please always post such messages to the mailing list than to me
directly, as others might also be interested in merging the patch or in
your other plugin.

PPS: The "TODO" file (http://vimperator.mozdev.org/TODO.html) lists
already some ideas, so does the bug tracker on
http://vimperator.mozdev.org. If you would like to join vimperator
development as an "official" author, it would be great since your
javascript knowledge seems to be very good :)