[Vimperator] un[let]

[Doug Kearns]

G'day Viktor,

Nice to see you back.

On 9/18/07, Виктор Кожухаров <vkojouharov at gmail.com> wrote:
> В вт, 2007-09-18 в 01:59 +0200, Martin Stubenschrott написа:
> > On Mon, Sep 17, 2007 at 10:36:44PM +0300, Виктор Кожухаров wrote:

<snip>

> This eval is "good enough" to implement what is needed for the :let
> mapleader stuff. So I have no plans to "fix" anything to it, unless some
> bug appears.

So "mapleader" is on it's way? Cool. :)

<snip>

> I think it's ready. The only thing I'm not quite sure of is the
> namespace of this eval function. It's clearly not in the range of the
> true vimscript eval, so it might go there. But I think in general, all
> vimscript functions should go into their own namespace, like
> "vimperator.vimscript". That way we can isolate them with the 'with'
> keyword, so that implementing the whole of vimscript sooner or later
> will be possible.

Is that your plan?  It hadn't even occurred to me that that was on the
pending feature list but I wouldn't complain if a VimScript parser
turned up.  I'd just always assumed that JS would fill that role.

> However, since this isn't what the vimscript eval will be, it shouldn't
> go into the vimscript namespace, rather, there should be another eval
> function in that namespace that calls it (and that can still way after
> you or I commit this).

Looks useful to me. Two quick comments:
- Options have a value property so you don't need to call getter() explicitly
- variableReference() should probably be a 'private' helper...at least for now.

> I'll wait for a comment from Doug before committing this.

No need to wait for me. :)

Thanks,
Doug