[Vimperator] what about this new feature?

[olivier.rossel at gmail.com]

I am interested in developping some patches for Vimperator.
Yichao, could you please send me the patch, so I have some ideas of
which file you changed, and which modification you made in order to
add a feature.

Thank you.
And long lives the Vimperator :)

On 9/10/07, Martin Stubenschrott <stubenschrott at gmx.net> wrote:
> On Mon, Sep 10, 2007 at 06:10:07PM +0800, yichao.zhang wrote:
> > I have implemented this feature:
> > press 'g' to Open (put) a URL based on the current selection contents
> > in a new buffer.
> > similar to 'P' that Open (put) a URL based on the current clipboard
> >
> > Now I have to do this with <C-v> + <C-c> + "P".
> > The new feature is very useful for me! :)
>
> Oh, windows ;) Since most vimperator users are probably on unix, they
> can straight ahead use P since the text is autocopied to the X11
> selection. Also vimperator uses 'Y' to copy text for windows users, so
> YP would also do the job for you until we have real visual mode
> mappings, then yP would do it.
>
> Or you could just :map g YP and have it work your way.
>
> > How can I commit my code?
>
> Usually just send the output of diff -u > selection.patch here - be sure
> to use a recent
> If you are on windows, you'll proably need cygwin to get a decent 'diff'
> command. In this case i don't think i'll accept the patch, since you can
> already do it easily with YP and if that's to long, just map it.
>
> > or what's your suggestions? Is 'g' a good mapping key?
>
> Definitly not, since g is the start of many longer mappings like gg or
> gP or go{a-z}.
>
> But cool, you are in vimperator development now, if you find other
> annoyances, please go ahead, and send patches (maybe first with
> discussing the feature on the mailing list to avoid it, that the patch
> won't be accepted then).
>
> Best regards,
>
> Martin
> _______________________________________________
> Vimperator mailing list
> Vimperator at mozdev.org
> http://www.mozdev.org/mailman/listinfo/vimperator
>