[Vimperator] :pageInfo small changes

Martin Stubenschrott stubenschrott at gmx.net
Sat Oct 27 05:14:31 PDT 2007


Hi Marco,

On Sat, Oct 27, 2007 at 06:18:39AM +0200, calmar wrote:
> Hi Martin,
> 
> I attached a patch with some minor changes.
> 
> I thought:
> 
> the filename and the kb and (I added lastModifed) belongs
> together.

Yeah, looks much better now.

> Then, there would be no care anymore about the <title> length,
> since it's the last item and can go until/over the end of the
> status-line.

yeah.

> Looks like this now in the case you like it:
> http://calmar.ws/tmp/info.png

Awesome! That's how it should like, great

> additionall the bytes looks now like that: 12'345'444 bytes,
> instad of 12345444 bytes.

Why not use the standard seperator ","? I think:
12,345,444 bytes looks best (at least for en-US locale users who use .
as a comma seperator)

> Cheers
> marco

Thanks, but the patch doesn't apply, as Doug seems to have changed
something since the diff?

Could you try to update the patch?

Also the patches looks so good, if you provide one more for a different
feature, i'll give you cvs write access, so you don't have the problems
of out-of-date diffs, if you want.

Martin

PS: Nice to see you got into the vimperator code so fast, so you see
your fears were unjustified, great work!


More information about the Vimperator mailing list