[Vimperator] [patch] Mappings refactoring

[Viktor Kojouharov]

On 5/29/07, Martin Stubenschrott <stubenschrott at gmx.net> wrote:
> On Tue, May 29, 2007 at 09:45:37AM +0300, Виктор Кожухаров wrote:
> > I reverted the flags so that the first one starts at 1 << 1.
>
> Why? 1 << 1 is 2, and I think, flags normally start with 1, 2, 4, 8, ...
A big oops on my part. Don't know what I was thinking :(
>
> > btw, the hint commands will also have to be changed to be objects. but
> > don't use strings to store a function and then eval it, since it's
> > slower than a closure.
>
> Yeah, I wanted to convert them to closures anyway.
>
> > As for the two flags afterwards (what is their
> > name, and what do they do exactly?), when they are added to the flags
> > attribute, make them start from 1 << 10. That way we won't need to
> > change them if we need to add more global flags later on.
>
> No, I don't see a reason for this, the reason why we have flags is, that
> the code doesn't have to care if the flag has a numeric value of 16 or
> 512, it uses the symbolic name, and this shouldn't have gaps.
>
> Also what two flags are you talking about?
>
> --
> Martin
> _______________________________________________
> Vimperator mailing list
> Vimperator at mozdev.org
> http://www.mozdev.org/mailman/listinfo/vimperator
>