[Vimperator] [patch] Mappings refactoring
Martin Stubenschrott
stubenschrott at gmx.net
Mon May 28 15:57:01 PDT 2007
On Sun, May 27, 2007 at 03:15:08PM +0300, Виктор Кожухаров wrote:
> actually, don't add it. I'll add it later, so that you can look at it
> (it won't break anything since it won't be used yet)
Ok, now I looked at it more closely and it really looks good.
There are only a few things I marked with XXX: in the repo for now,
which should be changed public->private.
Apart from that, the most challenging part now would be the integration
into the keyhandling code. For this to work, the API needs to be
slightly changed to return an array of partial commands.
I propose to add a third argument to:
this.get = function(mode, cmd)
to make it:
this.get = function(mode, cmd, partial)
If "partial" is given and true, it should _always_ return an array of
commands (with 0,1 or more entries), which start with cmd. Or do you
have an better idea or better name for "partial"?
--
Martin
More information about the Vimperator
mailing list