[Vimperator] [patch] Mappings refactoring

[Виктор]

В нд, 2007-05-27 в 13:41 +0200, Martin Stubenschrott написа:
> On Fri, May 25, 2007 at 06:37:23PM +0300, Виктор Кожухаров wrote:
> > Ok, this is the second draft of the mappings. You should find it very
> > close to the one you suggested, though I added a few things.
> 
> Thanks, that looks much better, and I will have a 2nd look later and add
> it to the repository.
actually, don't add it. I'll add it later, so that you can look at it
(it won't break anything since it won't be used yet)
> 
> Just one question: why use this.__XXX() functions? I would rather like
> these things to be privately defined as:
> 
> function XXX()
> {
> 
> }
> 
> so that these functions can't be called from outside the Mappings()
> class.
Out of habit. I'll change it.
> 
> > the process of converting the mappings array to map objects is going to
> > be very painstaking though.
> 
> I know, but I really think, at the end, this will turn out much cleaner.
Once I commit it, you can finish that up :). I've already converted
quite a lot of the mappings, but I'm getting tired and annoyed of doing
the conversion.
> 
> But since all this code is in a seperate mappings.js, we could finish
> it before changing the keyprocessing code.
> _______________________________________________
> Vimperator mailing list
> Vimperator at mozdev.org
> http://www.mozdev.org/mailman/listinfo/vimperator
-- 
Виктор Кожухаров /Viktor Kojouharov/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: =?UTF-8?Q?=D0=A2=D0=BE=D0=B2=D0=B0?= =?UTF-8?Q?_=D0=B5?=
	=?UTF-8?Q?_=D1=86=D0=B8=D1=84=D1=80=D0=BE=D0=B2=D0=BE?=
	=?UTF-8?Q?_=D0=BF=D0=BE=D0=B4=D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=B0?=
	=?UTF-8?Q?_=D1=87=D0=B0=D1=81=D1=82?= =?UTF-8?Q?_=D0=BE=D1=82?=
	=?UTF-8?Q?_=D0=BF=D0=B8=D1=81=D0=BC=D0=BE=D1=82=D0=BE?=
Url : http://www.mozdev.org/pipermail/vimperator/attachments/20070527/218ffe4b/attachment.bin