[Vimperator] [patch] Mappings refactoring
Martin Stubenschrott
stubenschrott at gmx.net
Sun May 27 04:41:19 PDT 2007
On Fri, May 25, 2007 at 06:37:23PM +0300, Виктор Кожухаров wrote:
> Ok, this is the second draft of the mappings. You should find it very
> close to the one you suggested, though I added a few things.
Thanks, that looks much better, and I will have a 2nd look later and add
it to the repository.
Just one question: why use this.__XXX() functions? I would rather like
these things to be privately defined as:
function XXX()
{
}
so that these functions can't be called from outside the Mappings()
class.
> the process of converting the mappings array to map objects is going to
> be very painstaking though.
I know, but I really think, at the end, this will turn out much cleaner.
But since all this code is in a seperate mappings.js, we could finish
it before changing the keyprocessing code.
More information about the Vimperator
mailing list