[Vimperator] Fwd: Mozilla Add-ons: Vimperator Nomination

[Martin Stubenschrott]

It looks good that 0.5 will be available on addons.mozilla.org:

----- Forwarded message from Mozilla Add-ons <nobody at mozilla.org> -----

From: Mozilla Add-ons <nobody at mozilla.org>
Subject: Mozilla Add-ons: Vimperator Nomination
Date: Thu, 31 May 2007 21:59:32 -0700
To: stubenschrott at gmx.net
X-Mailer: PHPMailer [version 1.73]

Your nominated add-on, Vimperator, has been
reviewed by a Mozilla Add-ons editor who decided
to retain your add-on in the sandbox.

Review Information:
Reviewer: Shawn Wilsher
Comments: Sorry, but there are a few errors in the
error console with this:<br />
Error: win.res has no properties<br />
Source file:
chrome://vimperator/content/hints.js<br />
Line: 88<br />
 ----------<br />
Error: XULBrowserWindow.asyncUpdateUI is not a
function<br />
Source file:
chrome://browser/content/browser.js<br />
Line: 85<br />
<br />
The second one only appears with your extension
installed.<br />
<br />
In addition to this, I looked at the one error and
noticed that you used code from another extension,
which in itself isn't an issue, but when you leave
the names of the functions the same, can lead to
conflicts (especially when you modify this code in
any way).  The easiest way to fix this is to add a
unique prefix to function names (you can use vi's
global find and replace too!)<br />
<br />
Otherwise, I think this is a really neat idea, and
I'm impressed that someone implemented this.  With
these issues fixed, I think your extension stands
a good chance at making it public.

If you have questions about this review, please
e-mail amo-editors at mozilla.org or join #addons on
irc.mozilla.org.

Mozilla Add-ons
http://addons.mozilla.org

----- End forwarded message -----