[Vimperator] [patch]bookmark with keyword supported

[Martin Stubenschrott]

On Mon, Dec 10, 2007 at 09:07:33PM +0800, joshyu wrote:
> I am a newbie to vimperator and linux. but I really love this extension.
> I find the default add-bookmark doesn't support keyword,so I add some
> code and implement the function. because while using firefox, I do love
> to use its keyword.
> you can use it as following words:
> :bma  -t title -k keyword <url>

In the CVS version for FF3 you can already do this (and even use
--tags=pc,news to add tags to it), so this would be for the 0.5.3
version only, 0.6 already has it.

> the first patch of mine, please give advice. thanks.

I have not tested it, as i don't have a Firefox2 installed anymore,
maybe Doug will have a quick look and decide if it is worthwhile to add
to 0.5.3, or just wait for 0.6.

My actual advice is, if it is possible, please write patches for the 0.6
branch, as forward porting from 0.5.x is a lot of work, and i probably
think that 0.5.3 will be the last FF2 based version (unless Doug really
wants to keep up with porting).

However, at the first glance the patch seems fine, and I hope to get
more from you in future :)

--
Martin