[Vimperator] Can the tabs be numbered? & command "B"

[Lars Kindler]

Hi Martin,

1.) I am editing with vim and everything is very readable. Maybe the 
diff output is somehow messed up?

2.) BrowserStatusHandler seemed to only monitor the tab that is active, 
it wouldn't fire the event, when a
tab in the background was loaded. Now, every tab gets its own listener 
that reports back when a page is being loaded.

3.) It doesn't really need to. The only improvement if it depended on 
g_bufshow would be the preview_window loading
.2 seconds faster, or am I missing something? 

4.) I fixed this, see attached patches.

Lars

Martin Stubenschrott wrote:
> On Fri, Apr 20, 2007 at 04:48:29PM -0700, Lars Kindler wrote:
>   
>> Hi again,
>>
>> unfortunately the version I sent you didn't take into account tabs 
>> opened in the background and because of
>> timing issues "D" didn't influence the buffer preview. I attach a patch 
>> that fixes this and also adds the
>> functionality that the active tab is highlighted.
>>     
>
> 4 things, before I want to apply it:
>
> 1.) Also for you, please follow my coding style with 4 spaces (or if
> your editor can't do that, than at least one tab). With your "style",
> it's even hard to read when previewing before applying.
>
> 2.) Is there a reason, why you don't put the code into the
> nsBrowserStatusHandler in vimperator.js, lines 68+? Doesn't make sense
> to duplicate all this code.
>
> 3.) your setTimeout() seems to be unconditional of g_bufshow
>
> 4.) When the buffer preview window is opened with B, but afterwards
> another preview window with things like :bm, g_bufshow should be set of.
> If you are at it, you should also check for this.
> _______________________________________________
> Vimperator mailing list
> Vimperator at mozdev.mozdev.org
> http://www.mozdev.org/mailman/listinfo/vimperator
>   

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: commands.js.patch
Url: http://www.mozdev.org/pipermail/vimperator/attachments/20070421/7b3ac63a/attachment.ksh 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: completion.patch
Url: http://www.mozdev.org/pipermail/vimperator/attachments/20070421/7b3ac63a/attachment-0001.ksh