[Vimperator] Can the tabs be numbered? & command "B"
Martin Stubenschrott
stubenschrott at gmx.net
Fri Apr 20 17:41:47 PDT 2007
On Fri, Apr 20, 2007 at 04:48:29PM -0700, Lars Kindler wrote:
> Hi again,
>
> unfortunately the version I sent you didn't take into account tabs
> opened in the background and because of
> timing issues "D" didn't influence the buffer preview. I attach a patch
> that fixes this and also adds the
> functionality that the active tab is highlighted.
4 things, before I want to apply it:
1.) Also for you, please follow my coding style with 4 spaces (or if
your editor can't do that, than at least one tab). With your "style",
it's even hard to read when previewing before applying.
2.) Is there a reason, why you don't put the code into the
nsBrowserStatusHandler in vimperator.js, lines 68+? Doesn't make sense
to duplicate all this code.
3.) your setTimeout() seems to be unconditional of g_bufshow
4.) When the buffer preview window is opened with B, but afterwards
another preview window with things like :bm, g_bufshow should be set of.
If you are at it, you should also check for this.
More information about the Vimperator
mailing list