[Mozplugger] errors with Sun WorkShop cc

[Louis Bavoil]

On Thursday 21 April 2005 10:36, Stephane Despret wrote:
> Hello all,
> in the build of mozplugger 1.7.2 on Sparc Solaris 8 with un WorkShop 6
> update 2 C 5.3 Patch 111679-13 2003/09/29, I have had these errors :
>
> 1/
> It seems that __inline is not recognized by Sun cc, perhaps a definition
> in mozplugger.h like this
>
> #ifdef NO_INLINE
> #define __inline
> #endif
>
> could be correct this ?

Yes, I will fix the inline with solaris-cc in next release.

> 2/
> "mozplugger.c", line 893: invalid token: 1.7.2
> "mozplugger.c", line 901: invalid token: 1.7.2
>
> This is "VERSION" .. but I don't know why there is this error and how to
> correct it !!!

Try to replace VERSION by "1.7.2" (including the quotes) in the code.

> 3/
> "mozplugger.c", line 1242: syntax error before or at: attrib
> "mozplugger.c", line 1243: undefined symbol: attrib
> "mozplugger.c", line 1243: non-unique member requires struct/union
> object: override_redirect
> "mozplugger.c", line 1243: warning: left operand of "." must be
> struct/union object
> "mozplugger.c", line 1243: cannot access member of non-struct/union object
>
> attrib is defined on line 1242 and not at the beginning of NPP_SetWindow.

Yes, one way to fix this is to move "XSetWindowAttributes attrib;" to the 
first line of the function.

> 4/ In the Makefile, we have :
> DEFINES=$(STREAM) -DVERSION=\"$(VERSION)\" -Wall #-DDEBUG
> and
> RPM_OPT_FLAGS=-O2
>
> for all compilators and all platforms but -Wall and -O2 are gcc options.

Right, this should be fixed.

Louis