[Greasemonkey] GM_showPopup doesn't take into account frames

Michael Kraft mjk4984 at yahoo.com
Fri Dec 2 06:20:32 EST 2005


I noticed the GM_showPopup function in browser.js is set up to filter out
scripts which aren't applicable to the currently loaded page.  The problem is
that it doesn't take in to account frames so if the script doesn't include
the parent's URL, but does include a frames's URL it won't be listed when it
should be.  Similarly if a frame is excluded, but the parent is not it will be
displayed.

I coded a fix to browser.js which will check the frames as well as the main
url.  I'm attaching the new browser.js file.

I tried sending this and it never showed up on the list so I'm going to try and
zip the browser.js file in case that was the reason.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browser.zip
Type: application/force-download
Size: 5370 bytes
Desc: 639150430-browser.zip
Url : http://mozdev.org/pipermail/greasemonkey/attachments/20051202/5f1b35e0/browser.bin


More information about the Greasemonkey mailing list