[Greasemonkey] GM_showPopup doesn't take into account frames

Michael Kraft mjk4984 at yahoo.com
Thu Dec 1 13:52:59 EST 2005


I noticed the GM_showPopup function in browser.js is set up to filter out
scripts which aren't applicable to the currently loaded page.  The problem is
that it doesn't take in to account frames so if the script doesn't include the
parent's URL, but does include a frames's URL it won't be listed when it should
be.  Similarly if a frame is excluded, but the parent is not it will be
displayed.

I coded a fix to browser.js which will check the frames as well as the main
url.  I'm attaching the new browser.js file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browser.js
Type: application/x-javascript
Size: 18209 bytes
Desc: 1076584101-browser.js
Url : http://mozdev.org/pipermail/greasemonkey/attachments/20051201/3e7f4ea3/browser-0001.js


More information about the Greasemonkey mailing list