[Flashblock] Flashblock now with InstaBlock[TM]

[Philip Chee]

Hey guys,

I've fixed a long standing bug 12592:
<http://bugzilla.mozdev.org/show_bug.cgi?id=12592>

As you know we've always needed a short timeout before
swapping our placeholder in. All previous attempts
to remove the timeout caused the browser to crash.
However this timeout allows flash to run briefly and
this is particularly noticable on slower machines.
It also allows a class of very small flash that contains
only a loadURL() command to jump to an interstitial
advertisement (usually for a gambling or porn site).

I didn't manage to remove the requirement for the
timeout. However what I did was, as soon as we got
hold of the flash object/embed, to null out all
src, data and movie attributes, even before running
the showPlaceholder() function. And then to swap
these attributes back in when showing back the
original flash. According to reports from testers to
whom I emailed testing versions, this is working
great guns and everybody is as happy as a bunch of
clams with this "instant' blocking.

So I plan to release new versions of 1.5 and 1.3 next
week. But before I do could someone test the latest
1.5.unstable on linux platforms? Thanks.

Cheers.

Phil