[Flashblock] Request to make Flashblock with better with Adblock

[Lorenzo Colitti]

Lorenzo Colitti wrote:
> Just thinking: does adblock simply set "display: none;" on the content 
> it blocks? If so, when generating a placeholder we could simply check if 
> the underlying element has display: none and if so not show the 
> placeholder.
> 
> This of course assumes that adblock does its magic before we do, but 
> there might be a chance of that working since we create the placeholder 
> on a timeout and not in the XBL constructor.

Well, this doesn't appear to be the case. After the page is loaded, the 
Flash object blocked by adblock has display: none, but if I check to see 
if it's display: none when creating the placeholder, 
current.style.display is empty. I'm not going to pursue this further.

I would suggest that users of Flashblock who want it to play nice with 
adblock ask the adblock developers if there's a reliable and stable way 
we can use to detect if an object is blocked and if so not show the 
placeholder. I'm happy to add that to Flashblock, but I don't have time 
to look through the adblock code to figure out how it works and where we 
need to hook in.

Philip (ferrariTR512m), do you want to take this up with the adblock 
developers?


Cheers,
Lorenzo

-- 
Lorenzo Colitti                          http://www.colitti.com/lorenzo/