[Flashblock] Re: Flashblock revised XBL
Lorenzo Colitti
lorenzo at colitti.com
Wed Jan 4 12:52:52 EST 2006
Philip Chee wrote:
>> Right... if that's the cause of the problem, then the attached patch
>> should be enough to fix it with a minimum of code changes.
>> Unfortunately, I don't have a Windows box to test on. Can you check
>> if it fixes the problem?
>
>> I attach flashblock.xml too in case you can't use the diff somehow.
>
> This hasn't been checked into the CVS?
I hadn't checked it in yet, because I didn't know if it fixed the
problem since I can't reproduce the bug. :)
>> Thanks for your help so far!
>
> Any I can confirm that this fixes the test case in bug 12680
> <http://bugzilla.mozdev.org/show_bug.cgi?id=12680>
> And I can't reproduce the problem for the newscientist and
> tomshardware test cases.
Ok, I've checked this in to the 1.5 branch now. Gary, thanks for
debugging the problem and suggesting the fix; Phil, thanks for testing. :)
Cheers,
Lorenzo
--
Lorenzo Colitti http://www.colitti.com/lorenzo/
More information about the Flashblock
mailing list