[Flashblock] Flashblock 1.5 steps before release

[Lorenzo Colitti]

Philip Chee wrote:
>> - I am reworking the installation code now so that all it does is
>>    remove the @import statement from userContent.css. We need to make
>>    sure this works for:
> 
> I've been meaning to look into this. The Window counting code you
> removed was part of my plan. Instead of onload every time a browser
> window is spawned, I thought that I would only run the remove
> function on first browser load. [...]

You're right: the current branch tip checks userContent.css on every 
startup to see if the @import is there, and if so removes it. If we care 
about the performance hit, a simple way to avoid it would be to use a 
pref such as flashblock.migrated, default false, and set it to true once 
the @import statement has been removed. I don't think this is critical 
though, what do you think?

> 				if ((!gFlashblockEnabled) &&
> 					("@mozilla.org/content/style-sheet-service;1" in Components.classes)) {
> 					Flashblock.removeImportFromUserStylesheet('userContent.css');
> +++++++++++++++++++++++++++++++++++
> Could you remove this for me on the 1.5BRANCH?

Done.

> There are one or two sIFR styles that I need to move from .css to
> .xbl for FF 1.5; previously they were crashing FF 1.0.7 if put in
> the xbl.

Ok. Will you take care of that? I won't be touching those files.


Cheers,
Lorenzo

-- 
Lorenzo Colitti                          http://www.colitti.com/lorenzo/