[Flashblock] Flashblock 1.5 steps before release

Philip Chee philip.chee at gmail.com
Wed Nov 30 02:44:32 EST 2005


On 30/11/05, Lorenzo Colitti <lorenzo at colitti.com> wrote:

> - XBL has been refactored and works pretty well
>    - Under Linux with Flash 7, nothing slips through
>    - The placeholders should have the correct images
>    - I don't know about Flash 8/Win: is what we have the best we can

I've tested under FF1.5/Flash8/Win. Seems to work well on all
the test sites.

> - I am reworking the installation code now so that all it does is
>    remove the @import statement from userContent.css. We need to make
>    sure this works for:

I've been meaning to look into this. The Window counting code you
removed was part of my plan. Instead of onload every time a browser
window is spawned, I thought that I would only run the remove
function on first browser load. I've tested this out a bit but as
usual got distracted by something else.

Oops I've still got a bit of code attached to the prefObserver:
+++++++++++++++++++++++++++++++++++
				if ((!gFlashblockEnabled) &&
					("@mozilla.org/content/style-sheet-service;1" in Components.classes)) {
					Flashblock.removeImportFromUserStylesheet('userContent.css');
+++++++++++++++++++++++++++++++++++
Could you remove this for me on the 1.5BRANCH?

>   - Figure out what to do about Flash 8

The workarounds I made seem to be holding up reasonably well.
The base plugin bug regression is fixed on the trunk and targetted
at Gecko 1.8.0.1 which I guess corresponds to FF 1.5.0.1.

>   - Test new installation code.

> Any other things we need to do before we release? Phil, does anything
> come to mind? For example, can we remove the Seamonkey toolbar code?

Yuppers.

There are one or two sIFR styles that I need to move from .css to
.xbl for FF 1.5; previously they were crashing FF 1.0.7 if put in
the xbl.

Phil


More information about the Flashblock mailing list