[Flashblock] Flashblock and Firefox 1.5

[Philip Chee]

On 24/11/05, Lorenzo Colitti <lorenzo at colitti.com> wrote:
> Philip Chee wrote:

>> Not every flash is affected, just one out of say 20.

> Does this correlate with "this.block is not a function" errors?

I don't see much correlation actually.

>> <http://www.bakketun.net/test/flash.html>
> I don't see this, all three are consistently blocked for me using latest
> branch Flashblock with Firefox 20051121.

I'll retest with the latest RC3

>> Checking for a custom attribute (or actually any attribute) on
>> the flash object will cause this problem, because we've removed
>> it from the DOM, and the FP8 scriptable object is pointing to a
>> garbage location in memory.

> So what happens then? Does Firefox crash?

No, but the JS red [X] error causes the js engine to stop executing
our script at this point. The visible effect is that clicking on
the FB placeholder does not unblock the flash.

> But actually, that solution doesn't look too bad or hackish to me.
> Can't we use it all the time?

Yes we can.

> Or is there something hackish I'm missing?

Just the irritating annoyance that we need a couple of extra lines
in the code. Otherwise it's fine.

Phil