[Flashblock] Flashblock and Firefox 1.5

[Lorenzo Colitti]

Philip Chee wrote:
>> I'm looking at it now, but I can't see this. What URL are you using?
> 
> Not every flash is affected, just one out of say 20.

Does this correlate with "this.block is not a function" errors?

> <http://www.bakketun.net/test/flash.html>
> 
> Third flash object has a flashblock placeholder prepended to it
> but is otherwise not blocked. Perhaps I screwed up when I refactored?

I don't see this, all three are consistently blocked for me using latest 
branch Flashblock with Firefox 20051121.

> I think I put them back into the FB 1.5 XBL. Basically:
> 
> function flashblockShowFlash() {
> //	if("prevHeight" in current) {
> 	if(placeholder.flashblock == "frame") {
> 
> Checking for a custom attribute (or actually any attribute) on
> the flash object will cause this problem, because we've removed
> it from the DOM, and the FP8 scriptable object is pointing to a
> garbage location in memory.

So what happens then? Does Firefox crash?

But actually, that solution doesn't look too bad or hackish to me. Can't 
we use it all the time? Or is there something hackish I'm missing?


Cheers,
Lorenzo

-- 
Lorenzo Colitti                          http://www.colitti.com/lorenzo/