[Flashblock] Flashblock and Firefox 1.5

[Philip Chee]

On 24/11/05, Lorenzo Colitti <lorenzo at colitti.com> wrote:
> Philip Chee wrote:


> I'm looking at it now, but I can't see this. What URL are you using?

Not every flash is affected, just one out of say 20.

<http://www.bakketun.net/test/flash.html>

Third flash object has a flashblock placeholder prepended to it
but is otherwise not blocked. Perhaps I screwed up when I refactored?

> (BTW: if you have a suite of test cases, can you put them online?)

Done. <http://flashblock.mozdev.org/tests/testsbookmarks.html>

This is in Firefox bookmarks format so it won't validate, but it
can be imported into Mozilla, Seamonkey, and Firefox (and NS8).

> Hmm, I won't be able to see this because I'm on Linux and Flash 8 does
> not exist for Linux (yet?).

Hmmm. Perhaps Flashplayer 8 is causing other side effects?

>> it into FF 1.5 final and is targeted at Gecko 1.8.0.1. So it looks
>> like we can't take out the hacks I made to workaround this bug.

> Drat. What were the hacks you used?

I think I put them back into the FB 1.5 XBL. Basically:

function flashblockShowFlash() {
//	if("prevHeight" in current) {
	if(placeholder.flashblock == "frame") {

Checking for a custom attribute (or actually any attribute) on
the flash object will cause this problem, because we've removed
it from the DOM, and the FP8 scriptable object is pointing to a
garbage location in memory.

This doesn't affect frames/iframes as we are just hiding them
not removing them from the DOM.

Phil