[Companion] Menu-button fix

[Miles Libbey]

There appear to be some bugs that folks think have fixed
http://mozdev.org/bugs/show_bug.cgi?id=6954 has suggested code in it
http://mozdev.org/bugs/show_bug.cgi?id=5861 has some missing icons and
related code

http://mozdev.org/bugs/show_bug.cgi?id=4783 doesnt really have a
proposed fix, just points to a specific code problem

http://mozdev.org/bugs/show_bug.cgi?id=5179 has a patch attached to it,
but since it was done in feb, its not clear if its already in.

Should we try to get these patches in for this release?

miles


--- Brian Erst <azzipsderf-companion at yahoo.com> wrote:

> Attached is a new yahootoolbar.jar. It is built off of Brian
> Kennelly's
> latest build from 9/15 (the 9:11:50 build).
> 
> This version of the Companion toolbar fixes the menu-button problems
> that appeared in Firefox 0.9 and above. The toolbar menu-buttons
> (i.e.
> My Yahoo!, Mail, Finance, etc.) will now display in a horizontal
> (icon
> to the left) orientation and will work as both a button and as a
> menu.
> 
> The changes came in two files. In class_CompanionDisplayer.js, I
> removed the button.setAttribute("orient", "horizontal") line. The
> "orient" attribute is buggy in Firefox.
> 
> The second change is in yahootoolbar.css. I had to modify the
> menubutton orientation at the CSS level. The following lines were
> added
> to this file:
>  
> toolbarbutton.yahoobuttonmenu >
> .toolbarbutton-menubutton-button {
>   -moz-box-orient: horizontal;
> }
>  
>  
> With these two changes, the Brian Kennelly version of Companion (I
> think we're calling it 0.53) displays beautifully in Firefox. Moz
> Suite
> users should test to make sure it look good there as well.
> 
> - Brian Erst

> ATTACHMENT part 2 application/octet-stream name=yahootoolbar.jar
> _______________________________________________
> Companion mailing list
> Companion at mozdev.org
> http://mozdev.org/mailman/listinfo/companion
> 



=====
Miles Libbey 
Product Manager, Yahoo! Mail 
miles at yahoo-inc.com