[Companion] Oops

[Ryan McHale]

Hello,

   I have used Brian's jar.. I am just curious why the "Bookmarks" and
"Alarm Bell" (mail notification?) buttons work fine.  But the rest
work as described below with the arrow adjacent to the button?

Thanks,

Ryan


On Wed, 15 Sep 2004 10:02:45 -0700 (PDT), Brian Erst
<azzipsderf-companion at yahoo.com> wrote:
> It's definitely a bug/weird feature of Firefox. In Firefox 0.9 and
> 1.0PR, dynamically created menu buttons with a horizontal orientation
> are incorrectly rendered. Instead of a menu button, you get something
> more akin to a button + menu, where the button does nothing and the
> menu is accessed by an extra down arrow NEXT to the button.
> 
> So, unfortunately, the new yahootoolbar.jar that Brian has developed
> will not work as is with Firefox. You can make the same kludgy fix that
> I made for 0.52, which changes the horizontal orientation with vertical
> orientation. This makes the buttons big, fugly but useable.
> 
> You have to modify class_CompanionDisplayer.js, go to the
> buildButtonMenu method and comment out the following line:
> 
> button.setAttribute("orient", "horizontal");
> 
> i.e., change to:
> 
> //button.setAttribute("orient", "horizontal");
> 
> Again, it's an ugly workaround, but it does work.
> 
> - Brian Erst
> 
> 
> 
> > Scott wrote:
> >
> > >Sure go ahead and send it. I don't mind.  So...how about fixing the
> > >click ability of the buttons (they don't work).  They worked many
> > moons
> > >ago.
> > >
> > >
> > >
> > They work correctly in Netscape 7.2 and in Mozilla 1.8a3, so it is
> > probably a Firefox bug.  Maybe they may have changed the
> > implementation
> > of the toolbarbutton or menu-button classes.
> >
> > I prefer the suites, so I may not get around to looking at this
> > problem.
> >
> > _______________________________________________
> > Companion mailing list
> > Companion at mozdev.org
> > http://mozdev.org/mailman/listinfo/companion
> >
> 
> 
> 
> _______________________________________________
> Companion mailing list
> Companion at mozdev.org
> http://mozdev.org/mailman/listinfo/companion
>