[Jslib] peer review
Eric Plaster
plaster@visi.com
Sat, 10 Nov 2001 23:33:39 -0600
This is a multi-part message in MIME format.
--------------080908040206030107010907
Content-Type: multipart/alternative;
boundary="------------060606050106050506030604"
--------------060606050106050506030604
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
I got a bug <http://mozdev.org/bugs/show_bug.cgi?id=665>against file.js.
I fixed it, and would like to have someone look at it, as I'm not as
familar with it anymore...
I included a diff.
-eric
--
Eric Plaster
Urban Rage Software <http://www.urbanrage.com>
Senior Software Engineer
RPG tools project
rpgtools@urbanrage.com
http://rpgtools.mozdev.org
*/ AD&D tools for the player and the DM/*
--------------060606050106050506030604
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title></title>
</head>
<body>
<br>
I got a <a href="http://mozdev.org/bugs/show_bug.cgi?id=665">bug </a>against
file.js. I fixed it, and would like to have someone look at it, as I'm not
as familar with it anymore...<br>
<br>
I included a diff.<br>
-eric<br>
<br>
<div class="moz-signature">-- <br>
<table cellpadding="0" cellspacing="0" border="0" width="100%">
<tbody>
<tr>
<td valign="Top">Eric Plaster<br>
</td>
<td valign="Top" align="Right"><a href="http://www.urbanrage.com" style="color: maroon; text-decoration: none; ">
Urban Rage Software</a><br>
</td>
</tr>
<tr>
<td valign="Top"> Senior Software Engineer<br>
</td>
<td valign="Top" align="Right"> RPG tools project<br>
</td>
</tr>
<tr>
<td valign="Top"> <a class="moz-txt-link-abbreviated" href="mailto:rpgtools@urbanrage.com">rpgtools@urbanrage.com</a><br>
</td>
<td valign="Top" align="Right"><a href="http://rpgtools.mozdev.org" style="color: maroon; text-decoration: none; ">
http://rpgtools.mozdev.org<br>
</a></td>
</tr>
</tbody>
</table>
<div align="Center"><font color="#999999"><b><i><font color="#666666"><small>
AD&D tools for the player and the DM</small></font></i></b></font></div>
</div>
</body>
</html>
--------------060606050106050506030604--
--------------080908040206030107010907
Content-Type: text/plain;
name="file.js.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="file.js.diff"
Index: file.js
===================================================================
RCS file: /cvs/jslib/libraries/io/file.js,v
retrieving revision 1.74
diff -r1.74 file.js
666c666,668
< if(dest.exists() && !dest.isDirectory())
---
> dest.append(this.leaf);
>
> if(dest.exists())
699d700
< dest.append(this.leaf);
--------------080908040206030107010907--